London | 25-SDC-July | Mikiyas Gebremichael | Sprint 1 | Debugging - Hashtag Slowing Down the Browser#119
Open
Mikiyas-STP wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
…rk : by checking if the hashtag selected is alrady running or not
Mikiyas-STP
added
📅 Sprint 1
4 tasks
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
This works, but I have a few questions!
Comment on lines
+19
to
+20
| state.currentHashtag = hashtag; | ||
| state.hashtagBlooms = []; |
Member
There was a problem hiding this comment.
Are there any drawbacks to setting these here? Is it set anywhere else?
Author
There was a problem hiding this comment.
Thankyou @illicitonion , these values are only set inside the hashtagview and there is no conflict. but if i add more views later i should be careful about it.
| Jinja2==3.1.5 | ||
| MarkupSafe==3.0.2 | ||
| psycopg2==2.9.10 | ||
| psycopg2-binary==2.9.10 |
Member
There was a problem hiding this comment.
Why did you have to make this change? What did it fix? It seems unrelated to the bug being fixed here?
Author
There was a problem hiding this comment.
i was getting an error related to compiling the python code and the debugger suggested using "-binary" to use a version that doesn't require compiling.
illicitonion
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR is created to debug the Hashtag Slowing Down the Browser
Questions
no questions